Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a crash with uninitialized interactsh client #1251

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Fixed a crash with uninitialized interactsh client #1251

merged 5 commits into from
Nov 16, 2021

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Nov 15, 2021 •
edited
Loading

Proposed changes

Fixes #1249 crash. Also contains a number of fixes for the breaking test in dev since last major refactors

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 linked an issue Nov 15, 2021 that may be closed by this pull request
Crash with no-interactsh flag and templates having interact placeholders #1249
Closed
@Ice3man543 Ice3man543 changed the title Fixed a crash with uninitialized interactsh client [wip] Fixed a crash with uninitialized interactsh client Nov 15, 2021
@Ice3man543 Ice3man543 changed the title [wip] Fixed a crash with uninitialized interactsh client Fixed a crash with uninitialized interactsh client Nov 16, 2021
@ehsandeep ehsandeep added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 16, 2021
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 16, 2021
@ehsandeep ehsandeep merged commit 50a816f into dev Nov 16, 2021
@ehsandeep ehsandeep deleted the fix-interactsh-crash branch November 16, 2021 14:35
@Mzack9999 Mzack9999 linked an issue Nov 16, 2021 that may be closed by this pull request
Test TestHTTPOperatorExtract/kval is failing #1262
Closed
@Mzack9999 Mzack9999 mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
3 participants
@Ice3man543 @ehsandeep @Mzack9999